Patrick/medassist-ng
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: run one stock reminder catch-up after restart (#300)

Browse Source 
* fix: run one stock reminder catch-up after restart

* fix(backend): persist scheduler stock-check timestamp in reminder state
This commit is contained in:
Daniel Volz
2026-02-24 21:21:34 +01:00
committed by GitHub
parent 26475fd3d0
commit 7a32b2045e
2 changed files with 18 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/services/reminder-scheduler.ts
+15 -3
View File
@@ -567,6 +567,15 @@ ${getFooterPlain(language)}${isRepeatDaily ? `\n\n${tr.stockReminder.repeatDaily
}
async function checkAndSendReminder(logger: ServiceLogger): Promise<void> {
// Track stock-scheduler daily execution separately from intake updates.
// This prevents intake reminders from suppressing stock catch-up after restarts.
const state = loadReminderState();
const today = getTodayInTimezone();
saveReminderState({
...state,
lastStockSchedulerCheckDate: today,
});
// Get all user settings to iterate over each user
const allUserSettings = await getAllUserSettings();
@@ -689,6 +698,7 @@ async function checkAndSendReminderForUser(
saveReminderState({
lastAutoEmailSent: new Date().toISOString(),
lastAutoEmailDate: today,
lastStockSchedulerCheckDate: currentState.lastStockSchedulerCheckDate,
notifiedMedications: [...new Set([...currentState.notifiedMedications, userStockNotifiedKey])],
nextScheduledCheck: currentState.nextScheduledCheck,
lastNotificationType: "stock",
@@ -892,6 +902,7 @@ async function checkAndSendReminderForUser(
saveReminderState({
lastAutoEmailSent: new Date().toISOString(),
lastAutoEmailDate: today,
lastStockSchedulerCheckDate: currentState.lastStockSchedulerCheckDate,
notifiedMedications: [...new Set([...currentState.notifiedMedications, userPrescriptionNotifiedKey])],
nextScheduledCheck: currentState.nextScheduledCheck,
lastNotificationType: "prescription",
@@ -947,9 +958,10 @@ export function startReminderScheduler(logger: ServiceLogger): void {
const today = getTodayInTimezone();
const currentHour = getCurrentHourInTimezone();
// If it's past REMINDER_HOUR today in the configured timezone and we haven't checked today, run immediately
if (currentHour >= REMINDER_HOUR && state.lastAutoEmailDate !== today) {
logger.info("[Reminder] Missed today's check, running now...");
// If it's past REMINDER_HOUR today in the configured timezone and we haven't checked today, run one catch-up.
// This is intentionally a single current-state snapshot (no replay of missed days).
if (currentHour >= REMINDER_HOUR && state.lastStockSchedulerCheckDate !== today) {
logger.info("[Reminder] Missed today's check, running one catch-up snapshot (no historical replay)...");
checkAndSendReminder(logger).catch((err) => logger.error(`[Reminder] Error: ${err}`));
}
backend/src/utils/scheduler-utils.ts
+3
View File
@@ -483,6 +483,7 @@ export function getUpcomingIntakes(
export type ReminderState = {
lastAutoEmailSent: string | null;
lastAutoEmailDate: string | null;
lastStockSchedulerCheckDate: string | null;
notifiedMedications: string[];
nextScheduledCheck: string | null;
lastNotificationType: "stock" | "intake" | "prescription" | null;
@@ -505,6 +506,7 @@ export function createDefaultReminderState(): ReminderState {
return {
lastAutoEmailSent: null,
lastAutoEmailDate: null,
lastStockSchedulerCheckDate: null,
notifiedMedications: [],
nextScheduledCheck: null,
lastNotificationType: null,
@@ -524,6 +526,7 @@ export function parseReminderState(json: string): ReminderState {
return {
lastAutoEmailSent: saved.lastAutoEmailSent ?? null,
lastAutoEmailDate: saved.lastAutoEmailDate ?? null,
lastStockSchedulerCheckDate: saved.lastStockSchedulerCheckDate ?? null,
notifiedMedications: saved.notifiedMedications ?? [],
nextScheduledCheck: saved.nextScheduledCheck ?? null,
lastNotificationType: saved.lastNotificationType ?? null,