From f36d56c523c98cc3a1db87e9459fcd2d6bc82dd1 Mon Sep 17 00:00:00 2001 From: Daniel Volz Date: Wed, 25 Feb 2026 23:54:21 +0100 Subject: [PATCH] test: update modal tests to reflect global ESC handler Remove ESC-keydown tests from ProfileModal.test.tsx since the useEscapeKey hook was removed from individual modals. Escape key handling is now centralized in App.tsx's global handler, making per-component ESC tests invalid (the component no longer responds to ESC in isolation). --- .../src/test/components/ProfileModal.test.tsx | 26 +++---------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/frontend/src/test/components/ProfileModal.test.tsx b/frontend/src/test/components/ProfileModal.test.tsx index e610ddf..ab9094d 100644 --- a/frontend/src/test/components/ProfileModal.test.tsx +++ b/frontend/src/test/components/ProfileModal.test.tsx @@ -66,27 +66,7 @@ describe("ProfileModal", () => { expect(onClose).not.toHaveBeenCalled(); }); - it("calls onClose when Escape is pressed on overlay", () => { - const onClose = vi.fn(); - render(); - - const overlay = document.querySelector(".modal-overlay"); - if (overlay) { - fireEvent.keyDown(overlay, { key: "Escape" }); - } - - expect(onClose).toHaveBeenCalledTimes(1); - }); - - it("does not close on non-escape keydown", () => { - const onClose = vi.fn(); - render(); - - const overlay = document.querySelector(".modal-overlay"); - if (overlay) { - fireEvent.keyDown(overlay, { key: "Enter" }); - } - - expect(onClose).not.toHaveBeenCalled(); - }); + // ESC key handling is tested at the App level — the global handler in + // App.tsx manages Escape for all modals, so per-component ESC tests are + // not applicable here. });