feat: persist package amount metadata in backend (#356)
* feat: add package amount persistence and backend route support * test: align backend test schemas with medication metadata fields * fix(backend): restore intake usage normalizer for planner endpoint * fix(backend): keep export typing compatible before liquid-unit stack step
This commit is contained in:
Daniel Volz
GitHub
@@ -23,6 +23,607 @@ Use this block for each meaningful task:
|
||||
|
||||
## Entries
|
||||
|
||||
### 2026-02-28 (CI triage: Backend Tests failure on PR #356)
|
||||
|
||||
- 🧩 Task: Reproduce and fix `Backend Tests` CI failure on `feat/package-amount-backend`.
|
||||
- ✅ Decisions:
|
||||
- Reproduced local backend failure (`15` failing tests) with `500` responses from `POST /medications/usage`.
|
||||
- Identified root cause: `backend/src/routes/medications.ts` called `normalizeIntakeUsageForStock(...)` but helper export was missing from `backend/src/utils/scheduler-utils.ts`.
|
||||
- Added minimal helper implementation that normalizes finite positive usage values and keeps stock usage semantics centralized.
|
||||
- Re-ran targeted failing suites, then full backend suite; all passed.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/utils/scheduler-utils.ts`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None for backend test check; release handoff can proceed without push from this agent.
|
||||
|
||||
### 2026-02-28 (stacked branch validation: package amount + liquid units + topical no-depletion)
|
||||
|
||||
- 🧩 Task: Validate stacked branch readiness and make tests compatible with new medication/package semantics.
|
||||
- ✅ Decisions:
|
||||
- Confirmed stack order on `feat/topical-no-depletion-planner`: `7ebd253` -> `3954ed2` -> `e689720` -> `f9deb1b`.
|
||||
- Fixed backend in-memory test schemas (integration/planner/e2e-routes) to include new medication columns so route tests stop failing with fixture-level `500` errors.
|
||||
- Updated focused E2E selectors/assertions for schedule usage labels and planner stock wording after liquid/topical/package updates.
|
||||
- Stabilized medication lifecycle E2E edit flow by cleaning per-test medication state and using current edit-form labels.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/test/integration.test.ts`
|
||||
- `backend/src/test/planner.test.ts`
|
||||
- `backend/src/test/e2e-routes.test.ts`
|
||||
- `frontend/e2e/medication-edit.spec.ts`
|
||||
- `frontend/e2e/medication-lifecycle.spec.ts`
|
||||
- `frontend/e2e/planner-data.spec.ts`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Frontend lint still reports 12 pre-existing `noNestedTernary` warnings in `MedicationsPage.tsx` and `ReportModal.tsx` (outside this compatibility-fix scope).
|
||||
|
||||
### 2026-02-28 (package amount UX: numeric input only for tube and liquid)
|
||||
|
||||
- 🧩 Task: Remove `+/-` steppers for non-tablet package amount fields.
|
||||
- ✅ Decisions:
|
||||
- Replaced `FormNumberStepper` with a plain numeric text input for:
|
||||
- `tube` -> `Amount per tube`
|
||||
- `liquid_container` -> `Package amount`
|
||||
- Kept unit selectors read-only and fixed per domain rule:
|
||||
- `tube` unit fixed to `g`
|
||||
- `liquid_container` unit fixed to `ml`
|
||||
- Added component regression tests in mobile modal suite to validate the new input style and fixed units.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/test/components/MobileEditModal.test.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Existing unrelated `noNestedTernary` lint warnings remain in `MedicationsPage.tsx` (pre-existing scope).
|
||||
|
||||
### 2026-02-28 (test update: tube grams + liquid ml regression coverage)
|
||||
|
||||
- 🧩 Task: Review and update tests for the new package-unit behavior rules.
|
||||
- ✅ Decisions:
|
||||
- Extended existing `useMedicationForm` tests to assert `packageAmountUnit="ml"` for `liquid_container` defaults/locks.
|
||||
- Added regression test that `tube` enforces/keeps `packageAmountUnit="g"` even if UI attempts to set `ml`.
|
||||
- Added regression test that legacy `tube` records with `packageAmountUnit="ml"` are normalized to `g` during `startEdit`.
|
||||
- Refactored touched code paths to satisfy `noNestedTernary` lint in changed files.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/test/hooks/useMedicationForm.test.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Optional backend route-level validation for `tube+ml` remains open if full server-side enforcement is desired.
|
||||
|
||||
### 2026-02-28 (tube unit correction: no ml for tubes)
|
||||
|
||||
- 🧩 Task: Enforce domain rule from user feedback: tubes use `g`, not `ml`.
|
||||
- ✅ Decisions:
|
||||
- Removed `ml` choice from tube amount input in desktop and mobile edit forms (unit is fixed to `g`).
|
||||
- Added hard normalization so tube edit state and save payload always persist `packageAmountUnit="g"`.
|
||||
- Added payload guard so `liquid_container` is normalized to `packageAmountUnit="ml"`.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Optional backend validation hardening can be added later to reject historic `tube+ml` payloads server-side.
|
||||
|
||||
### 2026-02-28 (tube package UX simplification: 1 tube x 150 g)
|
||||
|
||||
- 🧩 Task: Make `tube` package fields intuitive and remove conflicting stock inputs.
|
||||
- ✅ Decisions:
|
||||
- Reworked stock UI for `packageType=tube` in desktop and mobile to show only `Tubes` + `Amount per tube` + computed total amount.
|
||||
- Removed `total/current amount` steppers for tube to avoid contradictory input combinations.
|
||||
- Save payload now normalizes tube values to a consistent amount model (`totalPills` and `looseTablets` derived from `packCount * packageAmountValue`).
|
||||
- Added i18n keys for tube-specific labels (`form.tubes`, `form.packageAmountPerTube`) in EN/DE.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If needed, align planner/report wording to explicitly display tube multiplication format (`NxY unit`) everywhere.
|
||||
|
||||
### 2026-02-28 (start date optional placeholder consistency)
|
||||
|
||||
- 🧩 Task: Make start-date hint consistent with other optional date fields.
|
||||
- ✅ Decisions:
|
||||
- Added `common.optional` placeholder to `Medication Start Date` in desktop and mobile edit forms.
|
||||
- Kept validation behavior unchanged (start date remains optional).
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None.
|
||||
|
||||
### 2026-02-28 (full implementation: liquid units + topical stock behavior + package amount metadata)
|
||||
|
||||
- 🧩 Task: Implement the approved suggestions end-to-end: liquid intake unit conversion, topical non-depleting stock logic, and package amount metadata.
|
||||
- ✅ Decisions:
|
||||
- Added persisted medication metadata fields `packageAmountValue` + `packageAmountUnit` (`ml|g`) in DB schema/migration and API/export/import mappings.
|
||||
- Extended intake model with `intakeUnit` (`ml|tsp|tbsp`) and conversion logic (`tsp=5 ml`, `tbsp=15 ml`) for stock calculations.
|
||||
- Enforced topical stock behavior as metadata-only depletion path in planner/reminder/frontend coverage calculations (`topical`/`tube` does not reduce stock in V1.1 behavior).
|
||||
- Added desktop+mobile parity UI for liquid intake-unit selection and package-amount metadata inputs.
|
||||
- Added EN/DE i18n keys for new fields and bumped export format to `1.3`.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `backend/src/services/reminder-scheduler.ts`
|
||||
- `backend/src/routes/export.ts`
|
||||
- `frontend/src/types/index.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/utils/schedule.ts`
|
||||
- `frontend/src/components/SharedSchedule.tsx`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Testing execution remains delegated to `@testing-manager` per governance.
|
||||
|
||||
### 2026-02-28 (topical non-measurable vs liquid measurable + tbsp conversion)
|
||||
|
||||
- 🧩 Task: Clarify that topical content should not affect stock math while liquid should, and define tablespoon conversion.
|
||||
- ✅ Decisions:
|
||||
- Updated `doku/package_types.md` so `topical` package amount is metadata-only (no depletion effect) in V1/V1.1.
|
||||
- Kept `liquid` as measurable stock with canonical `ml` deduction.
|
||||
- Added liquid intake conversion rules: `1 tsp = 5 ml`, `1 tbsp = 15 ml`.
|
||||
- Locked MedAssist conversion to medical metric convention (`tbsp=15 ml`), excluding regional culinary variants.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If approved for implementation: add intake-unit enum (`ml|tsp|tbsp`) and conversion logic in frontend/backend.
|
||||
|
||||
### 2026-02-28 (packaging quantity unit decision for liquids/topicals)
|
||||
|
||||
- 🧩 Task: Clarify how package amount should be measured for liquid and topical medications.
|
||||
- ✅ Decisions:
|
||||
- Added explicit recommendation in `doku/package_types.md` to introduce package quantity fields: `packageAmountValue` + `packageAmountUnit` (`ml|g`).
|
||||
- Documented default mapping: `liquid_container -> ml`, `tube(topical) -> g`, with manual override to `ml` for topical liquids.
|
||||
- Clarified separation between `doseUnit`, `packageAmountUnit`, and `strengthUnit`.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If approved, implement DB/API/frontend fields and migrations in a dedicated PR.
|
||||
|
||||
### 2026-02-28 (liquid_container regression tests implemented)
|
||||
|
||||
- 🧩 Task: Convert the checklist handoff into executable regression coverage for `liquid_container` and run targeted validation.
|
||||
- ✅ Decisions:
|
||||
- Added backend real-route regression tests in `e2e-routes.test.ts` for create/share semantics and invalid liquid/package combination rejection.
|
||||
- Added frontend hook regression tests in `useMedicationForm.test.ts` for `liquid_container` form derivation (`medicationForm=liquid`, `doseUnit=ml`) and lock behavior.
|
||||
- Fixed outdated in-memory test schema in `e2e-routes.test.ts` by adding missing medication columns (`medication_form`, `pill_form`, `lifecycle_category`, `medication_end_date`, `auto_mark_obsolete_after_end_date`) so current route inserts can be tested reliably.
|
||||
- Executed only targeted test names to isolate new behavior from unrelated legacy failures in the larger file.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/test/e2e-routes.test.ts`
|
||||
- `frontend/src/test/hooks/useMedicationForm.test.ts`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Optional next step: expand backend package/form matrix coverage beyond these focused regressions.
|
||||
|
||||
### 2026-02-28 (testing-manager handoff checklist for liquid_container)
|
||||
|
||||
- 🧩 Task: Create a concrete test handoff checklist after user confirmation.
|
||||
- ✅ Decisions:
|
||||
- Added a dedicated `@testing-manager` section to `doku/package_types.md` with backend validation cases, frontend desktop/mobile parity checks, data exchange checks, and E2E minimum scenarios.
|
||||
- Kept checklist scoped to the `liquid_container` rollout and package/form invariants.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Execute the checklist via `@testing-manager` ownership path.
|
||||
|
||||
### 2026-02-28 (liquid_container rollout)
|
||||
|
||||
- 🧩 Task: Implement dedicated liquid package type end-to-end (`liquid_container`) after user decision.
|
||||
- ✅ Decisions:
|
||||
- Added `liquid_container` to backend and frontend package type contracts.
|
||||
- Enforced compatibility: `liquid -> liquid_container`, `topical -> tube`, `capsule/tablet -> not tube/not liquid_container`.
|
||||
- Updated desktop/mobile medication forms with explicit `liquid_container` option and fixed unit/label behavior (`ml`) in planner/schedule/dashboard/detail/report flows.
|
||||
- Updated backend planner/reminder/export/refill/share logic to treat `liquid_container` as container stock semantics where applicable.
|
||||
- Updated `doku/package_types.md` constraints to reflect new canonical mapping.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `backend/src/routes/export.ts`
|
||||
- `backend/src/routes/refills.ts`
|
||||
- `backend/src/routes/share.ts`
|
||||
- `backend/src/routes/planner.ts`
|
||||
- `backend/src/services/reminder-scheduler.ts`
|
||||
- `frontend/src/types/index.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/pages/PlannerPage.tsx`
|
||||
- `frontend/src/pages/SchedulePage.tsx`
|
||||
- `frontend/src/pages/DashboardPage.tsx`
|
||||
- `frontend/src/components/MedDetailModal.tsx`
|
||||
- `frontend/src/components/ReportModal.tsx`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Run full regression via `@testing-manager` (ownership rule).
|
||||
|
||||
### 2026-02-28 (logic correction: liquid cannot be in tube)
|
||||
|
||||
- 🧩 Task: Fix package-type logic after user report that `liquid` in `tube` is invalid.
|
||||
- ✅ Decisions:
|
||||
- Backend validation changed to `topical -> tube` and `liquid != tube`.
|
||||
- UI for `packageType=tube` now only allows `topical`; the `liquid` option was removed in desktop and mobile edit flows.
|
||||
- Form defaults/derivations for `tube` now force `medicationForm=topical` with `doseUnit=units`.
|
||||
- Updated source-of-truth plan wording in `doku/package_types.md` to match corrected logic.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Re-check if a dedicated `liquid` package path should be modeled explicitly in a future master-plan phase.
|
||||
|
||||
### 2026-02-28 (package-type hardening pass implemented)
|
||||
|
||||
- 🧩 Task: Implement as much of the package-type remediation as possible before the master-plan rollout.
|
||||
- ✅ Decisions:
|
||||
- Hardened backend API validation in `medications.ts` by adding inverse compatibility rule (`capsule/tablet` cannot use `tube`).
|
||||
- Updated frontend planner and schedule views to stop pill-only wording for `tube` medications and to render form-aware units.
|
||||
- Updated backend planner/reminder notification wording to avoid pill assumptions for `tube` and use form-aware/generic unit terms.
|
||||
- Extended backend translation common keys with unit terms required for the updated notification wording.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `frontend/src/pages/PlannerPage.tsx`
|
||||
- `frontend/src/pages/SchedulePage.tsx`
|
||||
- `backend/src/routes/planner.ts`
|
||||
- `backend/src/services/reminder-scheduler.ts`
|
||||
- `backend/src/i18n/translations.ts`
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Test ownership remains with `@testing-manager`; full four-form regression coverage still pending.
|
||||
|
||||
### 2026-02-28 (package_types full-plan refresh to current implementation status)
|
||||
|
||||
- 🧩 Task: Review the full `doku/package_types.md` and bring it to the latest code-aligned state.
|
||||
- ✅ Decisions:
|
||||
- Added a dated status snapshot (`2026-02-28`) with explicit split between implemented and still-open items.
|
||||
- Removed scope ambiguity by changing V1 section into `already implemented` baseline plus `remaining work`.
|
||||
- Added explicit note that persisted lifecycle values are currently limited to `refill_when_empty|treatment_period`, while `ongoing` is runtime-derived.
|
||||
- Added progress interpretation to the 1:1 remediation section (verify-and-align for completed parts, prioritize known open gaps).
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Next implementation focus remains planner/schedule/reminder wording normalization and full four-form regression coverage.
|
||||
|
||||
### 2026-02-28 (package_types plan: added 1:1 remediation execution order)
|
||||
|
||||
- 🧩 Task: Write the full executable remediation order directly into `doku/package_types.md`.
|
||||
- ✅ Decisions:
|
||||
- Added a mandatory file-by-file sequence with explicit `file -> change -> acceptance` structure.
|
||||
- Included all previously identified impacted backend, frontend, i18n, test, e2e, and documentation files.
|
||||
- Added an execution gate: skipped files require explicit technical rationale, otherwise rollout is incomplete.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Execute the remediation in code in exactly this order and track skipped items with rationale.
|
||||
|
||||
### 2026-02-28 (package_types plan made coherent + full impact inventory)
|
||||
|
||||
- 🧩 Task: Adjust `doku/package_types.md` so the plan is coherent and explicitly lists all affected code/test/doc areas.
|
||||
- ✅ Decisions:
|
||||
- Fixed top-level contradiction by documenting current container reality as `blister|bottle|tube`.
|
||||
- Added a mandatory explicit affected-file inventory across backend routes/services/schema, frontend runtime surfaces, i18n, backend tests, frontend tests, and e2e specs.
|
||||
- Kept the no-partial-rollout enforcement and linked it to concrete file groups for execution control.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Implement remediation in code according to the newly enumerated file inventory (starting with planner/schedule wording and corresponding tests).
|
||||
|
||||
### 2026-02-28 (package type plan hardening against partial implementation)
|
||||
|
||||
- 🧩 Task: Strengthen `doku/package_types.md` so package/form changes cannot be considered done when only partial surfaces are updated.
|
||||
- ✅ Decisions:
|
||||
- Added a mandatory cross-layer implementation coverage section (backend validation, backend logic, desktop+mobile parity, read views, i18n, import/export/share, tests).
|
||||
- Added explicit definition of done: all checklist areas must be updated or explicitly marked not impacted with rationale.
|
||||
- Grounded follow-up review findings with concrete gap examples still visible in code (notably planner/schedule pill-only wording paths).
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Execute a dedicated cleanup pass for planner/schedule/backend planner notification wording and corresponding tests.
|
||||
|
||||
### 2026-02-28 (release-manager doc cleanup: remove app-feature example)
|
||||
|
||||
- 🧩 Task: Remove product-feature-specific text from `.github/agents/release-manager.agent.md` and keep it process-focused.
|
||||
- ✅ Decisions:
|
||||
- Replaced concrete app feature example under release notes guidance with a neutral, reusable template using placeholders.
|
||||
- Kept release process rules intact; only example content was generalized.
|
||||
- 📁 Files touched:
|
||||
- `.github/agents/release-manager.agent.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Optionally align the Breaking Changes heading example with the no-emoji rule in a separate doc cleanup pass.
|
||||
|
||||
### 2026-02-27 (dashboard overview tube unit fix)
|
||||
|
||||
- 🧩 Task: Fix dashboard medication overview showing `pill` for `tube` medications.
|
||||
- ✅ Decisions:
|
||||
- Replaced pill-based stock label in dashboard overview with tube-aware amount labels.
|
||||
- Added local dashboard helpers to render `tube` values as `ml` (liquid) or `applications` (topical).
|
||||
- Updated timeline dose/total tags in dashboard day blocks to use tube-aware units and suppress pill-weight mg details for tube.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/DashboardPage.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None.
|
||||
|
||||
### 2026-02-27 (date input placeholder casing fix)
|
||||
|
||||
- 🧩 Task: Keep `optional` placeholder text lowercase in date inputs instead of inherited uppercase styling.
|
||||
- ✅ Decisions:
|
||||
- Root cause is inherited `text-transform: uppercase` from `.form-grid label`.
|
||||
- Applied local override on `.date-input-display` (`text-transform: none`, `letter-spacing: normal`) to preserve calm, readable lowercase placeholder text.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/styles/schedule-mobile-edit.css`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None.
|
||||
|
||||
### 2026-02-27 (tube wording consistency in report exports)
|
||||
|
||||
- 🧩 Task: Complete tube-specific wording consistency in medication report exports (text + print/PDF).
|
||||
- ✅ Decisions:
|
||||
- Added helper functions in `ReportModal` to centralize tube unit/label logic (`ml` vs `applications`).
|
||||
- Replaced pill-centric wording with amount-based wording for `tube` in current stock, total capacity label, intake schedule entries, and refill history entries.
|
||||
- Hid `Dose per pill` row for `tube` in both text and print report outputs.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/components/ReportModal.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Dashboard/Planner wording parity should be rechecked in a dedicated pass if product wants full app-wide amount terminology normalization for tube.
|
||||
|
||||
### 2026-02-27 (holistic package-specific UI behavior for tube)
|
||||
|
||||
- 🧩 Task: Make package tab behavior fully package-specific so `tube` does not show pill/mg-oriented fields.
|
||||
- ✅ Decisions:
|
||||
- For `tube`, relabeled stock fields from pill terminology to amount terminology.
|
||||
- Hid the pill-specific strength field (`Dose per pill`) for `tube` in desktop and mobile package tabs.
|
||||
- Adjusted total display text for `tube` to avoid `pill/pills` wording.
|
||||
- Added tube-form default unit behavior: `liquid -> ml`, `topical -> units`.
|
||||
- Added EN/DE i18n keys for amount-based labels.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Optional backend extension: distinguish volume-based depletion for liquid vs application-based depletion for topical in planner/reminder calculations.
|
||||
|
||||
### 2026-02-27 (align package_types doc with implemented tube/liquid/topical behavior)
|
||||
|
||||
- 🧩 Task: Resolve contradiction between implementation and `doku/package_types.md` technical constraints.
|
||||
- ✅ Decisions:
|
||||
- Updated constraints to reflect actual support for `packageType=blister|bottle|tube`.
|
||||
- Documented current UX split:
|
||||
- `blister`/`bottle` use `pillForm`.
|
||||
- `tube` uses `medicationForm` (`liquid`/`topical`).
|
||||
- Removed stale claim that only `blister|bottle` are supported end-to-end.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Keep docs in lockstep with model/UI changes to avoid product-level confusion.
|
||||
|
||||
### 2026-02-27 (restore liquid vs topical distinction for tube)
|
||||
|
||||
- 🧩 Task: Reintroduce meaningful liquid/topical distinction after pillForm-first simplification removed explicit tube subform choice.
|
||||
- ✅ Decisions:
|
||||
- Keep `pillForm` as primary for non-tube packages.
|
||||
- For `packageType=tube`, show `medicationForm` selector with only `liquid` and `topical` options.
|
||||
- Tube intake behavior now respects selected tube subform:
|
||||
- `liquid` -> fractional intake allowed, `usageMl` label.
|
||||
- `topical` -> integer/application-style intake, `usageApplication` label.
|
||||
- Default when switching to tube is now `liquid` unless an existing tube subform already exists.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If stock math for liquid should be volume-precise vs application-based, add explicit unit/policy handling in backend planner/reminder calculations.
|
||||
|
||||
### 2026-02-27 (pillForm-first UX: removed medicationForm selector)
|
||||
|
||||
- 🧩 Task: Remove semantically redundant `medicationForm` vs `pillForm` user choice and make `pillForm` the primary user-facing control.
|
||||
- ✅ Decisions:
|
||||
- Removed `medicationForm` selector from desktop and mobile forms.
|
||||
- Kept `pillForm` as the user-facing form mechanic for non-tube package types.
|
||||
- Kept `packageType` explicit (`blister`, `bottle`, `tube`) and derive `medicationForm` internally on save for backend compatibility.
|
||||
- Intake behavior now keys off `packageType`/`pillForm` in UI logic (fraction rule + usage labels).
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If liquid vs topical needs separate user-facing control later, add it only with concrete behavior differences.
|
||||
|
||||
### 2026-02-27 (remove non-functional lifecycle selector from UI)
|
||||
|
||||
- 🧩 Task: Ensure users only see options with concrete app impact.
|
||||
- ✅ Decisions:
|
||||
- Removed `lifecycleCategory` selector from desktop and mobile medication edit forms because both options currently have no distinct runtime behavior.
|
||||
- Kept persistence/internal field compatibility untouched to avoid DB/API churn in the same scope.
|
||||
- Documented that lifecycle selector remains hidden until it drives differentiated planner/reminder/stock behavior.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If lifecycle should return as a visible control, implement real behavior differences first and then re-enable UI.
|
||||
|
||||
### 2026-02-27 (package type pivot: liquid/topical use tube, not bottle)
|
||||
|
||||
- 🧩 Task: Complete cross-layer pivot after user correction that liquid/topical must not use pill-bottle semantics.
|
||||
- ✅ Decisions:
|
||||
- Introduced/propagated dedicated `tube` package type in backend validation/export and frontend domain/UI types.
|
||||
- Enforced medication-form mapping: liquid/topical -> `tube`; capsule/tablet keep blister/bottle options.
|
||||
- Standardized stock logic so container semantics (`bottle` and `tube`) use direct loose/total capacity handling across planner/dashboard/detail/refill/report/scheduler.
|
||||
- Added missing i18n keys for tube labels in form/report contexts (EN/DE).
|
||||
- 📁 Files touched:
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `backend/src/routes/export.ts`
|
||||
- `backend/src/routes/refills.ts`
|
||||
- `backend/src/routes/planner.ts`
|
||||
- `backend/src/routes/share.ts`
|
||||
- `backend/src/services/reminder-scheduler.ts`
|
||||
- `frontend/src/types/index.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/hooks/useRefill.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/pages/DashboardPage.tsx`
|
||||
- `frontend/src/pages/PlannerPage.tsx`
|
||||
- `frontend/src/components/MedDetailModal.tsx`
|
||||
- `frontend/src/components/ReportModal.tsx`
|
||||
- `frontend/src/utils/stock.ts`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Tests are owned by `@testing-manager`; no test execution was performed in this step.
|
||||
|
||||
### 2026-02-27 (rest_api_med_overview plan improved)
|
||||
|
||||
- 🧩 Task: Improve `doku/feat/rest_api_med_overview.md` based on review findings.
|
||||
- ✅ Decisions:
|
||||
- Added missing mandatory test workstream (backend, frontend, e2e).
|
||||
- Corrected rate-limit implementation target to existing architecture (`share.ts` + plugin in `backend/src/index.ts`).
|
||||
- Clarified response contract details: token format validation, `Cache-Control: no-store`, date format (`YYYY-MM-DD`), `shareStockStatus=false` nulling behavior.
|
||||
- Clarified image strategy for v1: reuse existing image filename + `/api/images/...` flow (no new share image proxy endpoint in this phase).
|
||||
- Updated effort estimate and explicitly recommended PR split due to scope size.
|
||||
- 📁 Files touched:
|
||||
- `doku/feat/rest_api_med_overview.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- If strict 500-line PR target must be enforced, execute as 3 linked PRs.
|
||||
|
||||
### 2026-02-27 (review of shared overview API plan completeness)
|
||||
|
||||
- 🧩 Task: Review `doku/feat/rest_api_med_overview.md` for quality and completeness.
|
||||
- ✅ Decisions:
|
||||
- Plan is directionally good, but not complete for implementation-readiness.
|
||||
- Critical gaps identified: missing explicit test workstream, incorrect/unclear target file for rate-limit wiring (`backend/src/app.ts` does not exist), and unresolved image-delivery contract for share overview payload.
|
||||
- Confirmed project uses `backend/src/index.ts` for Fastify plugin registration and already has `@fastify/rate-limit` registered globally.
|
||||
- Confirmed share tokens are generated via `randomBytes(8).toString("hex")` (16 hex chars), so token-format checklist is consistent with current implementation.
|
||||
- 📁 Files touched:
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Plan should be revised to include concrete backend/frontend/e2e tests and exact implementation locations before execution.
|
||||
|
||||
### 2026-02-27 (auth loading/error screen follows light/dark theme)
|
||||
|
||||
- 🧩 Task: Ensure the loading/connection screens shown before main app mount respect the selected theme.
|
||||
- ✅ Decisions:
|
||||
- Implemented theme resolution directly in `App.tsx` for pre-auth screens (`loading`, `authError`, `!authState`).
|
||||
- Read `localStorage.theme` and support `light`, `dark`, and `system` (matchMedia fallback).
|
||||
- Applied resolved theme via `data-theme` on the auth container so CSS variables immediately match the chosen theme.
|
||||
- 📁 Files touched:
|
||||
- `frontend/src/App.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None.
|
||||
|
||||
### 2026-02-27 (testing handoff + auth/registration env dependency clarification)
|
||||
|
||||
- 🧩 Task: User requested broad Playwright improvements (auth setup fallback, planner logic assertions, lifecycle integration, retry robustness, performance timeline tests) and asked whether login/registration behavior depends on env flags.
|
||||
- ✅ Decisions:
|
||||
- Applied governance rule from `.github/skills/medassist-testing-handoff/SKILL.md`: test planning/writing/execution must be delegated to `@testing-manager`.
|
||||
- Confirmed env dependency chain:
|
||||
- Backend source of truth: `getAuthState()` in `backend/src/plugins/auth.ts`.
|
||||
- `authEnabled` comes from `AUTH_ENABLED`.
|
||||
- `registrationEnabled` is `REGISTRATION_ENABLED || !hasUsers`.
|
||||
- `formLoginEnabled` is `needsSetup || (AUTH_ENABLED && FORM_LOGIN_ENABLED)`.
|
||||
- OIDC visibility/flow depends on `OIDC_ENABLED` (+ OIDC config vars).
|
||||
- Identified why current E2E auth setup can fail in SSO-only mode: `frontend/e2e/auth.setup.ts` assumes `#username/#password` are always present.
|
||||
- 📁 Files touched:
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Hand off requested Playwright implementation scope to `@testing-manager` with concrete file-level guidance.
|
||||
|
||||
### 2026-02-27 (intake reminder fallback removal)
|
||||
|
||||
- 🧩 Task: Make intake reminders strictly per-intake and remove medication-level fallback override.
|
||||
- ✅ Decisions:
|
||||
- In `backend/src/services/intake-reminder-scheduler.ts`, removed effective reminder condition `intake.intakeRemindersEnabled || med.intakeRemindersEnabled`.
|
||||
- Reminder eligibility is now strictly `intake.intakeRemindersEnabled`.
|
||||
- Removed medication-level fallback argument when parsing intakes for reminder checks (`parseIntakesJson(..., false)`).
|
||||
- Medication prefilter now checks whether any intake has `intakeRemindersEnabled=true`.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/services/intake-reminder-scheduler.ts`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Legacy medications that relied only on medication-level reminder flag will no longer trigger reminders until intake-level flags are enabled.
|
||||
|
||||
### 2026-02-27 (remove legacy `medassist.db` leftovers)
|
||||
|
||||
- 🧩 Task: Investigate why `backend/data/medassist.db` and `data/medassist.db` existed and remove old-path remnants.
|
||||
- ✅ Decisions:
|
||||
- Verified runtime DB path is `medassist-ng.db` via `getDbPaths()` in `backend/src/db/db-utils.ts`; no production code references `medassist.db`.
|
||||
- Found remaining string references only in `backend/src/test/db-client.test.ts` mocks/assertions.
|
||||
- Updated those test references to `medassist-ng.db` and removed legacy files `backend/data/medassist.db` and `data/medassist.db` from disk.
|
||||
- 📁 Files touched:
|
||||
- `backend/src/test/db-client.test.ts`
|
||||
- `backend/data/medassist.db` (removed)
|
||||
- `data/medassist.db` (removed)
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- None; global search shows no remaining `medassist.db` code references.
|
||||
|
||||
### 2026-02-27 (split-and-ship all pending local changes)
|
||||
|
||||
- 🧩 Task: Split one large local working tree into coherent PRs and merge all to `main` end-to-end.
|
||||
@@ -363,3 +964,51 @@ Use this block for each meaningful task:
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- `frontend check` remains blocked by unrelated TypeScript errors in other files (outside MedDetailModal test scope).
|
||||
|
||||
### 2026-02-27 (package types plan decision lock)
|
||||
|
||||
- 🧩 Task: Capture user-approved decisions for lifecycle derivation and V1 scope in package type planning.
|
||||
- ✅ Decisions:
|
||||
- `ongoing` is derived from `endDate == null` and should not be stored as an explicit lifecycle value.
|
||||
- V1 form scope remains exactly 4 forms (`Capsule`, `Tablet`, `Liquid`, `Topical`) without subforms.
|
||||
- `autoMarkObsoleteAfterEndDate` default is `true`.
|
||||
- Updated wording to remove ambiguous `restore` label in lifecycle section.
|
||||
- 📁 Files touched:
|
||||
- `doku/package_types.md`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Reflect these locked decisions in implementation tickets before coding starts.
|
||||
|
||||
### 2026-02-27 (implemented V1 medication form model in web app)
|
||||
|
||||
- 🧩 Task: Implement the approved V1 medication-form concept end-to-end on website (desktop + mobile) with persistence.
|
||||
- ✅ Decisions:
|
||||
- Added persisted fields: `medicationForm`, `pillForm`, `lifecycleCategory`, `medicationEndDate`, `autoMarkObsoleteAfterEndDate`.
|
||||
- Kept `ongoing` derived only: no explicit stored `ongoing` value introduced.
|
||||
- Enforced validation rules:
|
||||
- `pillForm` required for capsule/tablet medication forms.
|
||||
- fractional intake forbidden for capsule.
|
||||
- liquid/topical restricted to bottle container.
|
||||
- Implemented automatic obsolete marking during medication fetch when end date has passed and auto-mark toggle is enabled.
|
||||
- Preserved desktop/mobile parity by adding identical form controls to `MedicationsPage` and `MobileEditModal`.
|
||||
- Updated export/import format to include new metadata (`EXPORT_VERSION` bumped to `1.2`).
|
||||
- 📁 Files touched:
|
||||
- `backend/src/db/schema.ts`
|
||||
- `backend/src/db/db-utils.ts`
|
||||
- `backend/src/routes/medications.ts`
|
||||
- `backend/src/routes/export.ts`
|
||||
- `backend/drizzle/0011_stiff_randall_flagg.sql`
|
||||
- `backend/drizzle/meta/_journal.json`
|
||||
- `backend/drizzle/meta/0011_snapshot.json`
|
||||
- `frontend/src/types/index.ts`
|
||||
- `frontend/src/hooks/useMedicationForm.ts`
|
||||
- `frontend/src/pages/MedicationsPage.tsx`
|
||||
- `frontend/src/components/MobileEditModal.tsx`
|
||||
- `frontend/src/i18n/en.json`
|
||||
- `frontend/src/i18n/de.json`
|
||||
- `frontend/src/test/components/MobileEditModal.test.tsx`
|
||||
- `doku/memory_notes.md`
|
||||
- `doku/report.md`
|
||||
- 🔜 Follow-up/open points:
|
||||
- Full repo-wide frontend `npm run check` still reports unrelated pre-existing e2e formatting issues outside this scope.
|
||||
|
||||
Reference in New Issue
Block a user